You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basic integration of Valiant360 webGL library to view 360-degree photos and videos within sigal gallery. Modification of galleria theme, click VR icon or on the active image to open modal.
Hi,
Thanks for the PR, this seems to be a nice feature. However I'm not sure to want this in the core galleria theme, because this means more dependencies, and for each release it is a lot of work to update all the dependencies to their latest versions and check that everything still works.
What would think about putting this in another repository, like the 153957-theme (which can be pip-installed, which is great but not strictly necessary) ? The theme could then be referenced in https://github.com/saimn/sigal/wiki with other community efforts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic integration of Valiant360 webGL library to view 360-degree photos and videos within sigal gallery. Modification of galleria theme, click VR icon or on the active image to open modal.